Skip to content

refactor(#5785): replace glob & minimatch #5787

Draft
SukkaW wants to merge 7 commits intomochajs:mainfrom
SukkaW:replace-glob-minimatch-with-tinyglobby-picomatch
Draft

refactor(#5785): replace glob & minimatch #5787
SukkaW wants to merge 7 commits intomochajs:mainfrom
SukkaW:replace-glob-minimatch-with-tinyglobby-picomatch

Conversation

@SukkaW
Copy link
Contributor

@SukkaW SukkaW commented Mar 6, 2026

PR Checklist

Overview

The PR replaces glob and micromatch with tinyglobby, picomatch, and braces.

@SukkaW SukkaW changed the title Replace glob minimatch with tinyglobby picomatch refactor(mochajs#5785): replace glob & minimatch Mar 6, 2026
@SukkaW SukkaW changed the title refactor(mochajs#5785): replace glob & minimatch refactor(#5785): replace glob & minimatch Mar 6, 2026
@codecov
Copy link

codecov bot commented Mar 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.70%. Comparing base (2e07be1) to head (0a8ebc4).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5787      +/-   ##
==========================================
- Coverage   88.73%   88.70%   -0.04%     
==========================================
  Files          66       66              
  Lines        4742     4729      -13     
  Branches      976      973       -3     
==========================================
- Hits         4208     4195      -13     
  Misses        534      534              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SukkaW SukkaW force-pushed the replace-glob-minimatch-with-tinyglobby-picomatch branch from 5e41a17 to 91f2f83 Compare March 6, 2026 15:23
@SukkaW SukkaW force-pushed the replace-glob-minimatch-with-tinyglobby-picomatch branch from 91f2f83 to 0a8ebc4 Compare March 6, 2026 16:30
@SukkaW SukkaW marked this pull request as draft March 7, 2026 08:12
@SukkaW
Copy link
Contributor Author

SukkaW commented Mar 7, 2026

watch intergration tests on Windows are failing, still looking into this.

@mark-wiemer
Copy link
Member

mark-wiemer commented Mar 7, 2026

@SukkaW you can consider integrating changes with #5409 and seeing if that works. I will be pushing to get that PR into 12.0 as well, I've just been extremely busy* these past ~5 weeks. I promise things will calm down after Wednesday of next week and I'll be more active ;)

@SukkaW
Copy link
Contributor Author

SukkaW commented Mar 7, 2026

@mark-wiemer It appears that intergration test CI in #5409 is still failing (not yet fully fixed). Maybe it won't help after all. I will check out a new branch and rebase, though, to see if it actually works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

⚡️ Performance: Replace glob with tinyglobby

2 participants