refactor(#5785): replace glob & minimatch #5787
Draft
SukkaW wants to merge 7 commits intomochajs:mainfrom
Draft
Conversation
glob & minimatch
glob & minimatch glob & minimatch
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5787 +/- ##
==========================================
- Coverage 88.73% 88.70% -0.04%
==========================================
Files 66 66
Lines 4742 4729 -13
Branches 976 973 -3
==========================================
- Hits 4208 4195 -13
Misses 534 534 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5e41a17 to
91f2f83
Compare
91f2f83 to
0a8ebc4
Compare
Contributor
Author
|
|
Member
Contributor
Author
|
@mark-wiemer It appears that intergration test CI in #5409 is still failing (not yet fully fixed). Maybe it won't help after all. I will check out a new branch and rebase, though, to see if it actually works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
globwithtinyglobby#5785status: accepting prsOverview
The PR replaces
globandmicromatchwithtinyglobby,picomatch, andbraces.