Skip to content

Conversation

@StephanZiegler
Copy link
Contributor

@StephanZiegler StephanZiegler commented May 29, 2018

Following @tobolar's suggestions in:

  1. Icons:
  • removed shading in icons for improved clearity in partial adaptor
  • added colored rounded rectangle in domain specific adaptors
  • unified sizing and location of real input icons
  1. Naming:
  • renamed XToYAdaptor to GeneralXToYAdaptor

close #2430

@AHaumer AHaumer merged commit 27d1926 into modelica:master May 29, 2018
@beutlich beutlich changed the title #2430 revised adaptor icons and nameing #2430 Revised adaptor icons and naming May 29, 2018
@beutlich beutlich added L: Blocks Issue addresses Modelica.Blocks L: Electrical.Analog Issue addresses Modelica.Electrical.Analog L: Mechanics.Rotational Issue addresses Modelica.Mechanics.Rotational L: Mechanics.Translational Issue addresses Modelica.Mechanics.Translational labels May 29, 2018
@beutlich beutlich added this to the maintenance milestone May 29, 2018
@StephanZiegler StephanZiegler deleted the 2430_revise_adaptors branch May 30, 2018 11:32
@tobolar
Copy link
Contributor

tobolar commented Jun 4, 2018

I guess the original icon of Modelica.Mechanics.Rotational.Components.AngleToTorqueAdaptor (and TorqueToAngleAdaptor) was fine since it really concerns particular components in Rotational library - in contrast to general adaptors. So grey shaded rectangle icon should be reused to be able to simply distinguish between that "flat" adaptor and the general one.
I would open new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

L: Blocks Issue addresses Modelica.Blocks L: Electrical.Analog Issue addresses Modelica.Electrical.Analog L: Mechanics.Rotational Issue addresses Modelica.Mechanics.Rotational L: Mechanics.Translational Issue addresses Modelica.Mechanics.Translational

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Obsolete adaptors in Mechanics.Rotational.Component

4 participants