Proposal: BankID "order ref token", not sure about naming#22
Merged
joeledstrom merged 5 commits intomasterfrom Aug 27, 2025
Merged
Proposal: BankID "order ref token", not sure about naming#22joeledstrom merged 5 commits intomasterfrom
joeledstrom merged 5 commits intomasterfrom
Conversation
joeledstrom
force-pushed
the
order-ref-token
branch
from
0ddf8a6 to
bae80c8
Compare
|
joeledstrom
force-pushed
the
order-ref-token
branch
from
bae80c8 to
baff0d6
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Contributor
|
The approach feels very reasonable |
larsve
reviewed
Aug 26, 2025
Contributor
larsve
left a comment
larsve
left a comment
There was a problem hiding this comment.
Just one issue, otherwise I think it look good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure this is a good idea. Only to be used for the "same device" flow.
We want to let twofer create and sign a JWT token when a BankID auth/sign is initiated. Which stores an encrypted orderRef, and the IP number of the client in its claims.
This token should then be verified in the collect endpoint. Where we make sure the IP stored in the token matches with the IP that called collect. and we decrypt the orderRef and use that for the collect request to the BankID API.