Skip to content

Add ability to override the download URL manually #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2025

Conversation

Ahajha
Copy link
Contributor

@Ahajha Ahajha commented May 23, 2025

No description provided.

@Ahajha Ahajha merged commit efd192b into main May 23, 2025
6 checks passed
@Ahajha Ahajha deleted the trotta/url-override branch May 23, 2025 19:15
@keith
Copy link
Contributor

keith commented Jun 5, 2025

how does this work for multiple platforms? since a toolchain can target N platforms but this is only 1 url?

@Ahajha
Copy link
Contributor Author

Ahajha commented Jun 5, 2025

that would need a little more work than I have here. worst case you can do a select? the target use case was just a local file override, where only the current platform matters.

@keith
Copy link
Contributor

keith commented Jun 5, 2025

you can't select in the module.bazel, maybe what this use case wants instead is a --override_repository? i guess the problem with that is you'd have to handle the BUILD file manually

@Ahajha
Copy link
Contributor Author

Ahajha commented Jun 5, 2025

ah right. yea i guess this just can't do multiplatform stuff then in its current state.

@Ahajha
Copy link
Contributor Author

Ahajha commented Jun 5, 2025

it gets a little weird because you'd need to plumb through a way to put the platform name in the url, and i don't know if there's a clear cut way to do that.

@keith
Copy link
Contributor

keith commented Jun 5, 2025

modeling after toolchains_llvm the solution would be to make urls or something as a dictionary of platform to url. i started on that somewhere but bailed since we didn't have a use case

@Ahajha
Copy link
Contributor Author

Ahajha commented Jun 5, 2025

yea open to suggestions here. the only use case we really have is testing with a local package for our nightly qualifications, so any other way we can do that is fine with me.

@keith
Copy link
Contributor

keith commented Jun 5, 2025

#8

@keith
Copy link
Contributor

keith commented Jun 5, 2025

i did have this one open

@Ahajha
Copy link
Contributor Author

Ahajha commented Jun 5, 2025

i wouldn't object to replacing this with that. i saw it at the time but not until i had already merged this one lol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants