-
Notifications
You must be signed in to change notification settings - Fork 195
feat : adds github workflow for automating dependency upgrade #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat : adds github workflow for automating dependency upgrade #90
Conversation
Snapshot versions are unavailable. Hence migrating to stable versions
…config chore(config): migrate renovate config
* fix : issue with running end to end tests * upgrade maven wrapper * fix issue with running circuit breaker
…r-plugin to v3.14.0 (#6) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…gin to v1.2.1 (#9) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…e-plugin to v3.5.3 (#7) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…n to v2.18.0 (#10) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…rity-jwt-jose to v5.0.0.build-snapshot (#4) * fix(deps): update dependency org.springframework.security:spring-security-jwt-jose to v5.0.0.build-snapshot * use replacement --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Raja Kolli <[email protected]>
…e-plugin to v3.5.3 (#8) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
- Replaced Lombok's @log4j2 annotation with explicit Log4j2 Logger instantiation in various classes across the project. - Updated GatewayConfiguration, GlobalControllerExceptionHandler, ServiceUtil, and multiple service implementations to use LogManager and Logger for logging. - Removed Lombok annotations from Product, Recommendation, Review, Event, and entity classes, replacing them with manual getter, setter, equals, hashCode, and toString methods. - Ensured consistent logging practices across all services, enhancing maintainability and readability of the codebase.
|
@mohamed-taman , can you please review and let me know if it looks good. As I am fixing one by one. This might become jumbo PR. |
|
@rajadilipkolli Thank you for your efforts; I appreciate them. Did you try running the entire system and the tests so we can ensure that the fixes were applied correctly? |
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
|
Hi @mohamed-taman , Sorry for late to respond. Somehow it didn't show in my email. Yes I did test end to end, also in CI workflow included running end to end tests by spinning docker container and it becomes successful only if all are working including resilience testing sample workflow logs |
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
|
@rajadilipkolli, thanks for the great job. At least the system is up and running, but the test failed at the end with the following message: Test OK (actual value: Product Id: 14 not found in fallback cache!) If you can fix it, it will be great to be able to merge the pull request. |
|
Hi @mohamed-taman , I will check and revert, it is weird, because the same code in my main branch is working without fail at below link |
* chore(deps): update dependency maven to v3.9.11 * Increase timeout --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Raja Kolli <[email protected]>
|
Hi @mohamed-taman , I have fixed by increasing the wait time and it is working now, Can you please let the workflow run |
|
@rajadilipkolli, it gives the same error. Try to increase the wait time to 30 seconds. |
|
Hi @rajadilipkolli, It failed again, and note that I am not running it on my machine; it is on the Github environment. It is not about increasing the wait time because this means a performance problem. The service is currently not operational, so any increase in wait time for the test will not resolve the issue. We need to investigate why the service is not operational. Check this error message:
|
…n to v2.19.0 (#42) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* feat : downgrade to Java 11 for debugging the build issue. * fix : compilation issues * fix issue with starting application * fix warning while building docker image * fix: add equals, hashCode, and toString to maintain value semantics
Hi @mohamed-taman , I have increased timeout to 25 sec due to below reasoning waitDurationInOpenState for the product circuit breaker is still configured to 20 s (see microservices/product-composite-service/src/main/resources/application.yml). By sleeping only 10 s we’ll check Line 218 while the breaker is still OPEN, so the assertion will now fail/flap. So increasing the wait comfortably above the configured duration I have downgraded to Java 11 temporarily so that I can make build pass Once this is done my next steps will be to slowly migrate to spring boot 2.4, 2.5 , 2.6 (supports Java 17) and so on... then I will again upgrade to java 17. |
…e-plugin to v3.5.4 (#43) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…r-plugin to v3.14.1 (#45) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…n to v2.19.1 (#47) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Uh oh!
There was an error while loading. Please reload this page.