Skip to content

Conversation

@rajadilipkolli
Copy link

@rajadilipkolli rajadilipkolli commented Mar 8, 2024

  • Adds renovate which automatically updates the version when all tests are passed and workflow which tests that nothing is broken
  • removes lombok
  • add Github workflow to test end to end functionality
  • upgrades maven and maven wrapper

rajadilipkolli and others added 16 commits March 8, 2024 12:45
Snapshot versions are unavailable. Hence migrating to stable versions
…config

chore(config): migrate renovate config
* fix : issue with running end to end tests

* upgrade maven wrapper

* fix issue with running circuit breaker
…r-plugin to v3.14.0 (#6)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…gin to v1.2.1 (#9)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…e-plugin to v3.5.3 (#7)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…n to v2.18.0 (#10)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…rity-jwt-jose to v5.0.0.build-snapshot (#4)

* fix(deps): update dependency org.springframework.security:spring-security-jwt-jose to v5.0.0.build-snapshot

* use replacement

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Raja Kolli <[email protected]>
…e-plugin to v3.5.3 (#8)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
- Replaced Lombok's @log4j2 annotation with explicit Log4j2 Logger instantiation in various classes across the project.
- Updated GatewayConfiguration, GlobalControllerExceptionHandler, ServiceUtil, and multiple service implementations to use LogManager and Logger for logging.
- Removed Lombok annotations from Product, Recommendation, Review, Event, and entity classes, replacing them with manual getter, setter, equals, hashCode, and toString methods.
- Ensured consistent logging practices across all services, enhancing maintainability and readability of the codebase.
@rajadilipkolli
Copy link
Author

@mohamed-taman , can you please review and let me know if it looks good. As I am fixing one by one. This might become jumbo PR.

@mohamed-taman
Copy link
Owner

@rajadilipkolli Thank you for your efforts; I appreciate them. Did you try running the entire system and the tests so we can ensure that the fixes were applied correctly?

rajadilipkolli and others added 2 commits May 24, 2025 21:24
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@rajadilipkolli
Copy link
Author

rajadilipkolli commented Aug 26, 2025

Hi @mohamed-taman ,

Sorry for late to respond. Somehow it didn't show in my email. Yes I did test end to end, also in CI workflow included running end to end tests by spinning docker container and it becomes successful only if all are working including resilience testing

sample workflow logs

https://github.com/rajadilipkolli-learning/Springy-Store-Microservices/actions/runs/17239353901/job/48912000549

renovate bot added 2 commits August 26, 2025 18:47
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@mohamed-taman
Copy link
Owner

@rajadilipkolli, thanks for the great job. At least the system is up and running, but the test failed at the end with the following message:

Test OK (actual value: Product Id: 14 not found in fallback cache!)
Will sleep for 10 sec waiting for the CB to go Half Open...
wget: server returned error: HTTP/1.1 503 Service Unavailable
Test FAILED, EXPECTED VALUE: HALF_OPEN, ACTUAL VALUE: , WILL ABORT
Error: Process completed with exit code 1.

If you can fix it, it will be great to be able to merge the pull request.

@rajadilipkolli
Copy link
Author

Hi @mohamed-taman ,

I will check and revert, it is weird, because the same code in my main branch is working without fail at below link

https://github.com/rajadilipkolli-learning/Springy-Store-Microservices/actions/runs/17239565965/job/48912749657

* chore(deps): update dependency maven to v3.9.11

* Increase timeout

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Raja Kolli <[email protected]>
@rajadilipkolli
Copy link
Author

Hi @mohamed-taman ,

I have fixed by increasing the wait time and it is working now, Can you please let the workflow run

@mohamed-taman
Copy link
Owner

@rajadilipkolli, it gives the same error. Try to increase the wait time to 30 seconds.

Will sleep for 15 sec waiting for the CB to go Half Open...
wget: server returned error: HTTP/1.1 503 Service Unavailable
Test FAILED, EXPECTED VALUE: HALF_OPEN, ACTUAL VALUE: , WILL ABORT

@mohamed-taman
Copy link
Owner

mohamed-taman commented Aug 29, 2025

Hi @rajadilipkolli, It failed again, and note that I am not running it on my machine; it is on the Github environment.

It is not about increasing the wait time because this means a performance problem. The service is currently not operational, so any increase in wait time for the test will not resolve the issue.

We need to investigate why the service is not operational. Check this error message:

wget: server returned error: HTTP/1.1 503 Service Unavailable

renovate bot and others added 3 commits September 8, 2025 01:09
…n to v2.19.0 (#42)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* feat : downgrade to Java 11 for debugging the build issue.

* fix : compilation issues

* fix issue with starting application

* fix warning while building docker image

* fix: add equals, hashCode, and toString to maintain value semantics
@rajadilipkolli
Copy link
Author

Hi @rajadilipkolli, It failed again, and note that I am not running it on my machine; it is on the Github environment.

It is not about increasing the wait time because this means a performance problem. The service is currently not operational, so any increase in wait time for the test will not resolve the issue.

We need to investigate why the service is not operational. Check this error message:

wget: server returned error: HTTP/1.1 503 Service Unavailable

Hi @mohamed-taman ,

I have increased timeout to 25 sec due to below reasoning

waitDurationInOpenState for the product circuit breaker is still configured to 20 s (see microservices/product-composite-service/src/main/resources/application.yml). By sleeping only 10 s we’ll check Line 218 while the breaker is still OPEN, so the assertion will now fail/flap. So increasing the wait comfortably above the configured duration

I have downgraded to Java 11 temporarily so that I can make build pass

Once this is done my next steps will be to slowly migrate to spring boot 2.4, 2.5 , 2.6 (supports Java 17) and so on... then I will again upgrade to java 17.

renovate bot and others added 5 commits September 27, 2025 19:47
…e-plugin to v3.5.4 (#43)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…r-plugin to v3.14.1 (#45)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…n to v2.19.1 (#47)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants