Skip to content

Copy pnpm patches into the Docker build before install - #184

Merged
malkoG merged 1 commit into
devfrom
fix/docker-copy-pnpm-patches
Oct 9, 2026
Merged

malkoG merged 1 commit into
devfrom
fix/docker-copy-pnpm-patches

Conversation

@malkoG

@malkoG malkoG commented Oct 9, 2026

Copy link
Copy Markdown
Member

Summary

The Build and Push workflow on main started failing after #183: pnpm install --frozen-lockfile in the builder stage dies with ENOENT: no such file or directory, open '/app/patches/@fedify__fedify@2.4.2.patch'. The Dockerfile copies only package.json and pnpm-lock.yaml before installing, and pnpm.patchedDependencies needs the patch file at that point. This copies patches/ alongside them.

Why

  • The Fedify stopgap in Let remote curators feature Groups in their collections (FEP-7aa9) #183 is applied through pnpm.patchedDependencies, which pnpm resolves (and hashes) during install, before the later COPY . . runs.
  • Keeping the copy before install preserves the layer cache behavior: the install layer only invalidates when the manifest, lockfile, or a patch changes.

Commit History

  • Copy pnpm patches into the Docker build before install

Test Plan

  • docker build --target builder . succeeds locally
  • Build and Push on main goes green after merge

Assisted-By: Claude Code(claude-fable-5-1)

pnpm.patchedDependencies (added for the Fedify FEP-7aa9 stopgap) makes
pnpm read patches/*.patch during install, but the Dockerfile copied only
package.json and the lockfile at that stage, so the image build failed
with ENOENT on the patch file.

Co-authored-by: Claude Code <noreply@anthropic.com>
Assisted-By: Claude Code(claude-fable-5-1)
@coderabbitai

coderabbitai Bot commented Oct 9, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 34 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 66cce034-cca2-4075-96cd-e5725c3e9969

📥 Commits

Reviewing files that changed from the base of the PR and between f5c4b1a and 30e15f7.


📒 Files selected for processing (1)
  • Dockerfile


  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@malkoG
malkoG merged commit 5d4bb0b into dev Oct 9, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant