Both HTTP method and query can have a value of '0'#2280
Open
karenetheridge wants to merge 1 commit intomojolicious:mainfrom
Open
Both HTTP method and query can have a value of '0'#2280karenetheridge wants to merge 1 commit intomojolicious:mainfrom
karenetheridge wants to merge 1 commit intomojolicious:mainfrom
Conversation
Grinnz
reviewed
Oct 7, 2025
lib/Mojo/Message/Request.pm
Outdated
|
|
||
| # Query | ||
| $url->query->parse($env->{QUERY_STRING}) if $env->{QUERY_STRING}; | ||
| $url->query->parse($env->{QUERY_STRING}) if defined $env->{QUERY_STRING}; |
Contributor
Author
There was a problem hiding this comment.
Fair, an empty Mojo::Parameters in the url object is equivalent to not having one defined at all.
The Method ABNF is in https://datatracker.ietf.org/doc/html/rfc9110#appendix-A and is equivalent to the regex: ^[a-zA-Z0-9!#$%&'*+.^_`|~-]+$
karenetheridge
force-pushed
the
ether/zero-method-query
branch
from
a114334 to
c32767a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Method ABNF is in https://datatracker.ietf.org/doc/html/rfc9110#appendix-A and equivalent to the regex: ^[a-zA-Z0-9!#$%&'*+.^_`|~-]+$
I couldn't find a good place to test this, as parse_env is only called from the cgi and psgi tests; open to suggestion and will happily add some.