Develop -> Release 6.4.3 - #1370
Merged
Merged
Conversation
The `unset($items)` call only removed the local foreach variable, not the actual entry in `$orderLines`. When a discount line was iterated first and its totalAmount was less than remaining, the remaining value was inflated instead of the line being removed — causing product prices to be distorted by the full discount amount. This made the Mollie line totals diverge from the order total, triggering "An error occurred while initializing your payment". Fixed by using `unset($orderLines[$hash])` and skipping non-product lines (discount, shipping) so only physical/digital products are adjusted.
…ed" error Add early savePaymentStatus() call immediately after createOrder() on the Payment API path, matching the Order API path pattern (MOL-608, commit f236106). This writes order_id to mollie_payments right after order creation instead of at the end of webhook processing, eliminating the 5-27 second window where the return page cannot find the payment link and shows a false error to customers. Affected methods: iDEAL, Bancontact, PayPal and other Payment API methods. Order API methods (Klarna, in3) were not affected as they already had this fix.
…tion PIPRES-720: implement fallback to find correct payment
…into BUGFIX/PIPRES-720-payment-api-race-condition
…ce-condition PIPRES-720 Fix Payment API race condition causing false payment failed error
fix: Replace "&" to "and" in name to bypass validation rules
fix: geolocation and webhook fix with inactive country
PIPRES-727: redirect to order confirmation instead of custom page for banktransfer/card
…-id-bug INTERNAL: pay by bank transaction id update on open status
shippingAddress.givenName and familyName incorrectly referenced getBillingAddress() instead of getShippingAddress() in PaymentData.php
…ons on API properties
The React removal (PIPRES-601) dropped the tracking data fetch that pre-populated carrier, tracking number, and URL in the Ship modal. Add getShipmentInfo AJAX endpoint and fetch tracking on modal open.
…entData retry fallback
PIPRES-749: improve phone number validation causing 422 errors
PIPRES-749: Handle Pay by Bank payment cancellation with cart restoration
PIPRES:622: improvement hide subscription tab
…ovements PIPRES-719: admin order hook improvements
PIPRES-633 - PIPRES-631: add Croatian and Lithuanian translations
PIPRES-737: back office order creation bug
PIPRES-742: order creation improvement on failed description update
PIPRES-744: Implement association domain check and add banner in apple pay direct tab
…tive-country PIPRES-724: fix apple pay direct payment then country is not active in shop
BUG-FIX: race condition prevention bug fix
PIPRES-629: add new translations el, et, is, lv, ro, sk
PIPRES-742: Fix rounding distribution for whole-number differences in order line amounts
INTERNAL Code standards fixes, unit tests, stan error fixes
…g-prefill PIPRES-741 Restore shipment tracking pre-fill in Ship modal
…rs-api PIPRES-738 Restore partial quantity support for Orders API order line actions
# Conflicts: # src/DTO/PaymentData.php
…name PIPRES-735 Fix shipping address using billing name in Payments API
…eroundinginaccuracies PIPRES-726 Fix unset bug in compositeRoundingInaccuracies causing payment failures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every detail helps: versions, browser/server configuration, specific module/theme, etc. Feel free to add more information below this table.