Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses several critical bugs in the PayPal Express integration, primarily fixing intermittent checkout failures, incorrect address assignments, and validation issues with single-word names. It also adds comprehensive tests and detailed documentation for these fixes.
Bug Fixes:
PayPal Express Session Polling and Address Retrieval:
PayPalExpress.phpby correcting theSESSION_BASE_TIMEOUTfrom 2 ms to 0.5 seconds (500,000 µs) and moving the sleep to after the first API call. This ensures the system waits up to 7.5 seconds for address data from Mollie, resolving the "missing shipping address" intermittent failures. [1] [2]Name Handling and Validation:
givenName, thefamilyNameis reused as thegivenName. This prevents Shopware's required firstName validation from failing.Address Assignment:
CustomerService.php:defaultShippingAddressIdis correctly assigned and not set to the billing address ID.Testing and Documentation:
Automated Tests:
PayPalExpressLoadSessionTest.phpto verify the session polling logic, including immediate returns, retry behavior, and correct handling of the happy path.Documentation:
docs/learning/2026-04-10-paypal-express-intermittent-failures.md, explaining the bugs, fixes, and lessons learned.Changelog Updates: