Fix: Fall back to CustomerUser name for B2B addresses#58
Open
powli wants to merge 1 commit intomollie:masterfrom
Open
Fix: Fall back to CustomerUser name for B2B addresses#58powli wants to merge 1 commit intomollie:masterfrom
powli wants to merge 1 commit intomollie:masterfrom
Conversation
The Mollie API requires givenName and familyName on billing and shipping addresses. In B2B scenarios, ERP-imported addresses often only contain an organization name with no personal names. When the billing or shipping address lacks a first or last name, fall back to the CustomerUser's name which is always populated. Closes mollie#54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CustomerUser's namegivenNameandfamilyName— empty values cause incomplete order dataChanges
Mapper/MollieDtoMapper.php: After building the order DTO, check if the sourceOrderAddresshas empty first/last name, and if so, setgivenName/familyNamefrom the order'sCustomerUserTest plan
CustomerUser's name asgivenName/familyNameCloses #54