Fix: Add .rendered guard to prevent synchronizationSettings double-render error#62
Open
Sebastian80 wants to merge 1 commit intomollie:masterfrom
Open
Fix: Add .rendered guard to prevent synchronizationSettings double-render error#62Sebastian80 wants to merge 1 commit intomollie:masterfrom
Sebastian80 wants to merge 1 commit intomollie:masterfrom
Conversation
…-render error The transport form template renders form.parent.synchronizationSettings without checking if it was already rendered by Oro's update.html.twig. This causes a Twig error on OroCommerce 6.1.x where the logWarnings sync setting (added without an applicable restriction) makes synchronizationSettings.count > 0, triggering Oro's conditional render before the transport widget renders it again. Matches the pattern used by Oro's own IntegrationBundle form template.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
form.parent.synchronizationSettingswithout checking.rendered, causing a Twig double-render error on OroCommerce 6.1.xlogWarningssync setting (added without anapplicablerestriction) makessynchronizationSettings.count > 0for all integration types, triggering the conditional render inupdate.html.twigbefore Mollie's template renders the same field againChanges
Resources/views/Form/fields.html.twig: Addand not form.parent.synchronizationSettings.renderedto the existingis definedcheck, matching the guard pattern used by Oro's ownIntegrationBundle/Resources/views/Form/fields.html.twigTest plan
logWarningssync setting present)Closes #61