p2p: Prevent inaccurate missing spans when adding a block#10303
Open
j-berman wants to merge 1 commit intomonero-project:masterfrom
Open
p2p: Prevent inaccurate missing spans when adding a block#10303j-berman wants to merge 1 commit intomonero-project:masterfrom
j-berman wants to merge 1 commit intomonero-project:masterfrom
Conversation
28 tasks
Contributor
|
cc @jeffro256 would be good to have this merged before fcmp++-stage rebases again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents a data race where the
request_missing_objectsfunction ends up thinking a block span is missing when really the block(s) just got added to the db.Solves the last known cause of "runaway spans" identified on the stressnet.
This PR is arguably not an ideal solution (it jams a lock into the center of 2 large functions and carries some risk of deadlock), but barring a major rewrite to the sync protocol, it seemed the best short/medium term improvement to this section to me.
seraphis-migration#275