crypto: wipe AES key material before free#10344
Open
AskiiDev wants to merge 1 commit intomonero-project:masterfrom
Open
crypto: wipe AES key material before free#10344AskiiDev wants to merge 1 commit intomonero-project:masterfrom
AskiiDev wants to merge 1 commit intomonero-project:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
oaes_key_destroy()frees the AES key and expanded key buffers without clearing them first. This leaves key material in memory until the allocator reuses the blocks. This change wipes both buffers withmemwipe()before callingfree(), using the same pattern as elsewhere in the codebase.OpenAES is used by
cn_slow_hash(), including for wallet passphrase-derived key derivation; clearing this data reduces exposure of passphrase-derived material in freed heap.Note: #9508 proposes replacing the alloc-based OAES path with a buffer-based expansion; if that is merged, this change would be superseded. Until then, this wipes key material in the current implementation.