-
Notifications
You must be signed in to change notification settings - Fork 85
WIP - dependency experiments #2575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| * All CLI flags that are useful for {@link MongoshNodeRepl}. | ||
| */ | ||
| export type MongoshCliOptions = ShellCliOptions & { | ||
| type MongoshCliOptions = ShellCliOptions & { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this just removing all exports that aren't used elsewhere?
I think this is fine but I think this here would be a good example of a case where this type should be exported since it's definitely part of the module's API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, with the right configuration it can be smarter and figure out that this is meant to be a production exported file. that said I can disable it at this stage
| "lint": "prettier --check .", | ||
| "reformat": "prettier --write ." | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^ Are we sure about this? We should probably be expanding this file into a proper package.json instead of deleting it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah you predicted my eventual realization 😄
| "rimraf": "^3.0.2", | ||
| "semver": "^7.6.3", | ||
| "sinon": "^7.5.0", | ||
| "sinon": "^19.0.4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw, we should probably remove all or most packages here over time, this is a great step in that direction
Is that the primary goal here by itself? This sounds like an X-Y thing, like, what is the ultimate problem we're trying to solve? |
I'm going to split this up into multiple PRs once I reach a working point but there's a few things:
|
399d06a to
a0d139a
Compare
This introduces a stricter
knipdependency check and does some refactoring to make it possible to run workspace-specific installations for our tests in evergreen.WIP - seeing how well this works...