Remove assertion for verbose result #1835
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stIncMale
requested changes
Nov 1, 2025
| // Note: Previously, assertTrue(verboseResultsSetting) was used here because the server was not supposed | ||
| // to return successful operation results in the cursor when verboseResultsSetting is false. | ||
| // Due to server bug SERVER-113344, these unexpected results must be ignored until we stop supporting server | ||
| // versions with this bug. When that happens, restore assertTrue(verboseResultsSetting) here. |
There was a problem hiding this comment.
Let's leave a TODO-<JAVA ticket ID> tag here, and create a corresponding ticket, which is linked as "blocked by" / "depends on" (not sure what relations we have) to the aforementioned server ticket.
| writeModelIndex, | ||
| new ConcreteClientUpdateResult( | ||
| individualOperationResponse.getInt32("n").getValue(), | ||
| individualOperationResponse.getInt32("nModified", new BsonInt32(0)).getValue(), |
There was a problem hiding this comment.
It looks to me that this change, coming from #1823, should have also had a corresponding JAVA ticket describing that it is to be rolled back once https://jira.mongodb.org/browse/SERVER-113026 (it is not the same as the aforementioned SERVER-113344) is fixed and no version where the bug is present is supported. The TODO-<Jira ticket ID> tag will be needed here as well, to point to the place that needs to be changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JAVA-6001