Remove runtime-benchmarks feature flag from tests#3692
Open
manuelmauro wants to merge 2 commits intomasterfrom
Open
Remove runtime-benchmarks feature flag from tests#3692manuelmauro wants to merge 2 commits intomasterfrom
runtime-benchmarks feature flag from tests#3692manuelmauro wants to merge 2 commits intomasterfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe pull request modifies the CI workflow to add a dedicated compilation check for the runtime-benchmarks feature in isolation and removes this feature from the unit tests step, retaining only the evm-tracing feature for testing. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The runtime-benchmarks feature is not needed for running tests: - No test code uses any benchmark-gated API (try_successful_origin, ensure_successful, ensure_concluded, etc.) - The #[cfg] gates in the SDK are symmetric: when the feature is off, the extra trait methods don't exist in the trait definitions, so implementations don't need to provide them either. - All tests compile and pass without the feature.
62668dd to
75ca9ad
Compare
Contributor
Coverage Report@@ Coverage Diff @@
## master manuel/remove-runtime-benchmarks-from-tests +/- ##
===============================================================================
+ Coverage 77.10% 77.16% +0.06%
Files 389 389
+ Lines 76972 77269 +297
===============================================================================
+ Hits 59349 59622 +273
+ Misses 17623 17647 +24
|
Since runtime-benchmarks was removed from the test command, add a dedicated cargo check step to verify the feature still compiles. This mirrors the sole feature flag used by the benchmark cron workflow (check-benchmarks.yml / run-benches-for-runtime.sh).
arturgontijo
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the runtime-benchmarks feature flag from the unit test CI command (cargo test --profile testnet --workspace --features=evm-tracing,runtime-benchmarks), since it is not required for
running tests.
Motivation
The runtime-benchmarks feature was being enabled for the test suite despite no test code depending on any benchmark-gated API. Enabling it unnecessarily:
aren't exercising the real runtime configuration.
test suite.