Add HTTP wake support as alternative to Wake-on-LAN#1770
Open
stuckj wants to merge 9 commits intomoonlight-stream:masterfrom
Open
Add HTTP wake support as alternative to Wake-on-LAN#1770stuckj wants to merge 9 commits intomoonlight-stream:masterfrom
stuckj wants to merge 9 commits intomoonlight-stream:masterfrom
Conversation
* Add HTTP wake support as alternative to Wake-on-LAN This adds HTTP-based wake functionality for waking PCs over VPN networks (like Tailscale) where Layer-2 WOL magic packets cannot traverse. Features: - Per-host configuration via new "Configure Wake" context menu option - Choice between standard WOL or HTTP wake method - Simple HTTP GET request to user-configured URL - 10-second timeout with proper error handling The HTTP wake method is useful with services like tailscale-wakeonlan or UpSnap that provide HTTP endpoints for triggering WOL packets on the local network. Addresses: moonlight-stream#1251 Addresses: moonlight-stream#1672 * Add URL validation to Configure Wake dialog * Remove outdated comment about URL placeholders * Revert translation file changes (leave for maintainers to run lupdate) * Address Copilot review feedback for HTTP wake feature - Add host validation to isValidWakeUrl() to reject URLs without host - Fix timeout handling by using timedOut flag and aborting reply directly - Use deleteLater() for QNetworkReply cleanup per Qt best practices - Add processEvents() to ensure reply deletion before NAM destruction - Set initial OK button state in onOpened and guard onUrlValidChanged - Move ButtonGroup declaration before RadioButtons that reference it * More code review fixes. * More code review fixes. * More code review fixes.
This was referenced Dec 24, 2025
|
I think this would be a fantastic feature to combine with this project. |
Author
|
@cgutman, I don't know how you usually take contributions so just tagging in case you prefer to get a heads up about something being ready. Sorry to bug you if you'd prefer to get to PR contributions on your own time. |
Author
|
Any chance you can take a look at this @cgutman? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds HTTP-based wake functionality for waking PCs over VPN networks
(like Tailscale) where Layer-2 WOL magic packets cannot traverse.
Features:
The HTTP wake method is useful with services like tailscale-wakeonlan
or UpSnap that provide HTTP endpoints for triggering WOL packets on
the local network.
Addresses: #1251
Addresses: #1672