Allow resolution limits to be applied when "native" resolution is selected - #1805
Open
bradsk88 wants to merge 7 commits into
Open
Allow resolution limits to be applied when "native" resolution is selected#1805bradsk88 wants to merge 7 commits into
bradsk88 wants to merge 7 commits into
Conversation
When a native resolution is selected, users can now optionally specify maximum width and height limits. The effective resolution will be capped at these values while still detecting the monitor's native resolution.
This allows the limits UI to be shown in those cases.
Adds a context menu item that sends the Wake-on-LAN packet and automatically opens the PC's app view once it comes online, instead of requiring the user to wake it and then click it separately. Includes a 2-minute timeout with an error dialog if the PC does not come online.
After choosing Wake and Open, the PC view gave no feedback until the host came online, so the wait looked like a dead click. Add a modal NavigableMessageDialog with a BusyIndicator spinner that opens when the wake packet is sent and closes once the host is online (before the PC opens) or when the wake timeout fires. Matches the existing spinner dialog pattern used by the network test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the past, I had some issues rendering at the full resolution of my wacky, client-side monitor
That seems to be resolved, but I still find it useful to enforce an upper limit to the resolution while still allowing it to be flexible. In my case, I use my laptop computer as my client and it spends about 50% of the time on my lap (1080p) and 50% of the time connected to this very tall monitor.
Even without rendering issues, it can be nice to only use up part of the vertical space of the full screen. For example, if you run a 16:9 monitor in the vertical orientation but prefer working in a 4:3 aspect ratio.
Limits only show when "Native" is selected
"Native" now always shows up, even if it matches a preset resolution
Full Demo
limits.mp4