Skip to content

[BUG] Incorrect ACL Comment Parsing for Topics with Wildcard '#' #928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ieblYang wants to merge 2 commits into
base: main
Choose a base branch
from
+11 −1
Open

[BUG] Incorrect ACL Comment Parsing for Topics with Wildcard '#' #928

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad0acbc
[BUGFIX] Incorrect ACL Comment Parsing for Topics with Wildcard '#'
Jan 14, 2026
07a6df9
Merge branch 'main' into fix/update_endLineComment
ieblYang Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion broker/src/main/java/io/moquette/broker/security/ACLFileParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ public static AuthorizationsCollector parse(Reader reader) throws ParseException
Pattern commentLine = Pattern.compile("^#.*"); // As spec, comment lines should start with '#'
Pattern invalidCommentLine = Pattern.compile("^\\s*#.*");
// This pattern has a dependency on filtering `commentLine`.
Pattern endLineComment = Pattern.compile("^([\\w\\s\\/\\+]+#?)(\\s*#.*)$");
Pattern endLineComment = Pattern.compile("^(\\S+\\s+(\\S+\\s+)?[^\\s#]+(?:/[+#])?)(?:\\s+#.*)?$");
Matcher endLineCommentMatcher;

try {
Expand Down
10 changes: 10 additions & 0 deletions broker/src/test/java/io/moquette/broker/security/ACLFileParserTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,16 @@ public void testParseValidEndLineComment() throws ParseException {
assertTrue(authorizations.canWrite(new Topic("/weather/italy/anemometer"), "", ""));
}

@Test
public void testParseEndWithPoundTopicWithoutEndLineComment() throws ParseException {
Reader conf = new StringReader("topic /weather/italy/#");
AuthorizationsCollector authorizations = ACLFileParser.parse(conf);

// Verify
assertTrue(authorizations.canRead(new Topic("/weather/italy/#"), "", ""));
assertTrue(authorizations.canWrite(new Topic("/weather/italy/#"), "", ""));
}

@Test
public void testParseValidPoundTopicWithEndLineComment() throws ParseException {
Reader conf = new StringReader("topic /weather/italy/anemometer/# #simple comment");
Expand Down