Fix WinUIBackend & GtkBackend menu bar support#482
Merged
stackotter merged 1 commit intomainfrom Mar 11, 2026
Merged
Conversation
stackotter
force-pushed
the
stackotter/fix_winui_menu_bar
branch
2 times, most recently
from
5674b5d to
6d2fc47
Compare
stackotter
force-pushed
the
stackotter/fix_winui_menu_bar
branch
from
6d2fc47 to
d873fd6
Compare
stackotter
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #388, WinUIBackend hasn't been showing app menu bars, even though it did already have all the code required to support them. This was because I had some issues with them in the past and essentially disabled them by setting the menu bar height to zero.
This PR re-enables WinUIBackend menu bars. And to fix the issue that originally made me disable support for them, it hides the window menu bars when the menu is empty.
I had to make some changes to the
SceneGraphNodeprotocol in order to be able to compute the app's commands (menu bar items) before update each window's content, because whether or not the menu bar is empty now affects how much space is available in the windows (as the menu bar takes up window space when visible).As a side effect of the
SceneGraphNodeprotocol restructuring, I ended up resolving the GtkBackend menu bar support issues as well (I think because we could set the menu bar before showing the window).This PR fully resolves #388