Repository navigation
feat(setup): support Kimi Code client integrations - #1806
devloper961-maker wants to merge 1 commit into
Conversation
Register the user-level ~/.kimi-code/mcp.json entry (honoring a non-empty KIMI_CODE_HOME override), seed REA_MCP_INPUT_SCHEMA_PROFILE=compact so advertised schemas stay under Moonshot's per-schema cap, and cover detection, registration, and uninstall with boundary tests. Refs morluto#1791
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 37259604fc
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| client.name === "kimi_code" | ||
| ? Object.fromEntries( | ||
| Object.entries({ | ||
| REA_MCP_INPUT_SCHEMA_PROFILE: "compact", |
There was a problem hiding this comment.
When rea setup --client kimi_code --dry-run plans this write, SetupPlan.clientConfigurationDetail receives only providerEnvironment, so it reports “No additional provider environment variables” even though applying the plan adds this compact-profile variable. That makes the approved plan differ from the actual configuration mutation; pass the client-specific seed into the plan/detail so it is disclosed before approval.
AGENTS.md reference: AGENTS.md:L9-L9
Useful? React with 👍 / 👎.
| client.name === "kimi_code" | ||
| ? Object.fromEntries( | ||
| Object.entries({ | ||
| REA_MCP_INPUT_SCHEMA_PROFILE: "compact", |
There was a problem hiding this comment.
When a pre-existing Kimi registration has an owned REA command but neither its env nor the client process supplies REA_MCP_INPUT_SCHEMA_PROFILE=compact, readClientRegistrationStatuses still reports it as aligned because registrationAligned never examines this newly required setting. In that case scoped rea doctor --client kimi_code can report a healthy registration while Kimi sends the full schemas and Moonshot rejects every request; make the Kimi status stale when the profile seed is absent so doctor directs the user through setup.
Useful? React with 👍 / 👎.
|
Thanks for putting this together. This overlaps with #1804, which was opened shortly before this PR and also implements Kimi Code setup with the compact schema profile while addressing #1791. To avoid maintaining two competing implementations, I’m closing this PR in favor of #1804. The connection-and-recovery skill reference update here is useful and does not appear in #1804’s changed files; please consider carrying that small documentation addition over there. Thanks again for the contribution. |
2 participants
Summary
Adds Kimi Code (\kimi_code) to setup client integrations, following the #1301 / #1409 pattern:
Test Plan
pm run verify:test-discovery\ — 827 files, new test discovered
Notes
Closes #1791