Skip to content

Fix #421#422

Merged
mortbopet merged 5 commits intomortbopet:masterfrom
NLS-04:fix-#421
Dec 9, 2025
Merged

Fix #421#422
mortbopet merged 5 commits intomortbopet:masterfrom
NLS-04:fix-#421

Conversation

@NLS-04
Copy link
Contributor

@NLS-04 NLS-04 commented Nov 15, 2025

fixed bug stated in #421 by segregating the orignal tokenize function into a three step process.

for (auto line : llvm::enumerate(program)) {
  ...

  runOperation(tokens, tokenizeQuotes, tsl, line.value());

  runOperation(remainingTokens, splitCommentFromLine, tokens);

  runOperation(joinedParentheses, joinParentheses, tsl, remainingTokens );

  ...

@NLS-04 NLS-04 marked this pull request as ready for review November 15, 2025 14:26
@mortbopet
Copy link
Owner

LGTM - looks like formatting is off, though. Thank you for finding and fixing the issue :). Please add a test in the assembler tests to verify the fix.

@NLS-04
Copy link
Contributor Author

NLS-04 commented Nov 15, 2025

Added a test for the now corrected parentheses matching.
All tests pass sucessfully.

Totals: 20 passed, 0 failed, 0 skipped, 0 blacklisted, 5682ms
********* Finished testing of tst_Assembler *********

hopefully the clang workflow accepts this now
@mortbopet mortbopet merged commit a2158e4 into mortbopet:master Dec 9, 2025
6 checks passed
@mortbopet
Copy link
Owner

My apologies for the slow response - feel free to @ me in the future in case i forget to review :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants