Skip to content

Conversation

@HatulaPro
Copy link

@HatulaPro HatulaPro commented Aug 27, 2025

Implementing #49

Running 10000 small bbox queries from bench.js on my machine (no maxResults provided, using default):

Before:
14.086ms
13.47ms
14.196ms
13.818ms
13.005ms

Avg: 13.715ms

After:
14.913ms
14.432ms
14.443ms
14.134ms
14.438ms

Avg: 14.472ms

  • was considering passing it as an object in case we'd want more options in the future, let me know what you think

@HarelM
Copy link

HarelM commented Oct 3, 2025

@mourner, any chance you can take a look at this?

@mourner
Copy link
Owner

mourner commented Oct 22, 2025

@HarelM sorry, I got a bit concerned about the potential performance regression from this, looking at the benchmarks, so couldn't merge it right away, but haven't had a chance to dig deeper yet.

@HarelM
Copy link

HarelM commented Oct 22, 2025

Do let us know if there's anything we can do in order push this forward.
Another approach would be to create a new "API entry point" to facilitate this need and thus avoiding degradation in the current API.
But this might mean duplicating some of the code, which I'm not sure is a good idea.
But we'd love to know what you think should be the right solution and we'll be happy to move it forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants