Fix amend deprecation into moveit_ros folder

[mosfet80]

Description

amend_target_dependencies is deprecated - move to target_link_libraries()
cleaned moveit_ros folder

Checklist

• Required by CI: Code is auto formatted using clang-format
• Extend the tutorials / documentation reference
• Document API changes relevant to the user in the MIGRATION.md notes
• Create tests, which fail without this PR reference
• Include a screenshot if changing a GUI
• While waiting for someone to review your request, please help review another open pull request to support the maintainers

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (848c062) to head (726a7e5).

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #3664       +/-   ##
==========================================
- Coverage   46.24%   0.00%   -46.23%     
==========================================
  Files         726      51      -675     
  Lines       59483    5938    -53545     
  Branches     7624    1057     -6567     
==========================================
- Hits        27504       0    -27504     
+ Misses      31813    5938    -25875     
+ Partials      166       0      -166     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[urfeex]

@mosfet80 thank you for addressing this! I also started working on that a couple of weeks back but couldn't find the time to complete it. What is your main motivation only fixing deprecations in moveit_ros? Just to get a starting point? I assume that the others might have to be migrated, as well if things would want to get built in the future.

My main motivation to start working on that was to make the Qt6 port easier. Do you also have that on the agenda? Otherwise I would start working on that ontop of your changes.

[mosfet80]

@mosfet80 thank you for addressing this! I also started working on that a couple of weeks back but couldn't find the time to complete it. What is your main motivation only fixing deprecations in moveit_ros? Just to get a starting point? I assume that the others might have to be migrated, as well if things would want to get built in the future.

My main motivation to start working on that was to make the Qt6 port easier. Do you also have that on the agenda? Otherwise I would start working on that ontop of your changes.

The motivation is to remove deprecated functions. I can't compile moveit with the "rolling" version of ament_cmake_target_dependencies.
https://github.com/ament/ament_cmake/blob/rolling/ament_cmake_target_dependencies/CHANGELOG.rst
Unfortunately, it's not a quick fix.

I actually split the work into two commits: the first to overcome the ament_cmake deprecation and the second to compile with QT6.

As soon as I've completed the changes, I'll share the report containing both changes.

[urfeex]

That sounds great, then I'll keep my feed still.

The deprecated ament functions are not a showstopper for compiling on Rolling in my side (and I think neither in the build farm), but the Qt6 dependencies are. I still think, it's a good thing to combine both, as you'll have to touch a lot of link targets with the Qt6 migration, anyway.

Let me know, if I can be of any help and may it only be helping out in reviewing here.