-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Add FXIOS-14220 [perftest] Emit perfherder JSON artifact #30812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FXIOS-14220 [perftest] Emit perfherder JSON artifact #30812
Conversation
|
Hi @isabelrios :) |
b1a6bca to
d370291
Compare
|
sorry @junngo I looked at that but then missed it.. let me run the workflow for you and unblock this |
🧹 Tidy commitJust 2 file(s) touched. Thanks for keeping it clean and review-friendly! ✅ Per-file coverageAll changed files meet the threshold of 35.0%. Generated by 🚫 Danger Swift against ac74af8 |
jjSDET
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, let me know if you have any issues testing the workflow in bitrise for this.
…efox iOS performance tests
d370291 to
ac74af8
Compare
|
Thanks for helping me out :) |
|
🚀 PR merged to |
|
I triggered the Bitrise_performance workflow and I confirm that the json is generated and stored in artifacts: https://app.bitrise.io/build/84f421b3-09ac-4cf3-8275-4470817c51a8?tab=artifacts |
|
Oh, the file got generated properly. Thank you so much for helping with the code review and testing 🙌 |
yes it is :) Happy to help! thanks for this PR |

📜 Tickets
Jira ticket
Github issue
💡 Description
Firefox-ios performance tests currently only output
PERFHERDER_DATAto the log.This PR adds support for generating a perfherder-data JSON artifact (perfherder-data.json) to enable correct ingestion in Treeherder and downstream tooling.
📝 Checklist