Skip to content

Conversation

@junngo
Copy link
Contributor

@junngo junngo commented Nov 20, 2025

📜 Tickets

Jira ticket
Github issue

💡 Description

Firefox-ios performance tests currently only output PERFHERDER_DATA to the log.
This PR adds support for generating a perfherder-data JSON artifact (perfherder-data.json) to enable correct ingestion in Treeherder and downstream tooling.

📝 Checklist

  • I filled in the ticket numbers and a description of my work
  • I updated the PR name to follow our PR naming guidelines
  • I ensured unit tests pass and wrote tests for new code
  • If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • If adding telemetry, I read the data stewardship requirements and will request a data review
  • If adding or modifying strings, I read the guidelines and will request a string review from l10n
  • If needed, I updated documentation and added comments to complex code

@junngo junngo requested a review from a team as a code owner November 20, 2025 17:26
@junngo junngo requested a review from isabelrios November 20, 2025 17:26
@junngo junngo marked this pull request as draft November 20, 2025 17:29
@junngo junngo marked this pull request as ready for review November 20, 2025 17:37
@junngo junngo marked this pull request as draft November 20, 2025 17:37
@junngo
Copy link
Contributor Author

junngo commented Nov 20, 2025

Hi @isabelrios :)
I submitted a PR to solve the issue. From what I can see, jobs for firefox-ios only appear in Treeherder once the code has landed on main. Is there a way to trigger this perftest[0] job (or something equivalent) directly so that I can verify the perfherder JSON artifact before landing?

[0] example
https://treeherder.mozilla.org/jobs?repo=firefox-ios&fromchange=dab2846f826e986dd7b831534ff8f89eb75c6f82&selectedTaskRun=RMftNDvrQReJC56ppTDJUg.0

@junngo junngo force-pushed the generate-perfherder-artifact branch from b1a6bca to d370291 Compare November 21, 2025 06:31
@junngo junngo marked this pull request as ready for review November 21, 2025 06:36
@isabelrios
Copy link
Contributor

sorry @junngo I looked at that but then missed it.. let me run the workflow for you and unblock this

@mobiletest-ci-bot
Copy link

mobiletest-ci-bot commented Dec 3, 2025

🧹 Tidy commit

Just 2 file(s) touched. Thanks for keeping it clean and review-friendly!

✅ Per-file coverage

All changed files meet the threshold of 35.0%.

Generated by 🚫 Danger Swift against ac74af8

Copy link
Contributor

@jjSDET jjSDET left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, let me know if you have any issues testing the workflow in bitrise for this.

@junngo junngo force-pushed the generate-perfherder-artifact branch from d370291 to ac74af8 Compare December 3, 2025 18:33
@junngo
Copy link
Contributor Author

junngo commented Dec 3, 2025

Thanks for helping me out :)
The main goal of this patch is to generate the perfherder-data.json artifact.
I wanted to double check. Would it be possible to try running the bitrise-perf[0] job as well? Earlier on Bitrise I couldn’t find the job, so I’m asking again just in case.
[0] example job
https://treeherder.mozilla.org/jobs?repo=firefox-ios&selectedTaskRun=byQJ52HMQcuHuHL2ud3Cbw.0

@isabelrios isabelrios merged commit 1942aa2 into mozilla-mobile:main Dec 4, 2025
9 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2025

🚀 PR merged to main, targeting version: 146.1

@isabelrios
Copy link
Contributor

I triggered the Bitrise_performance workflow and I confirm that the json is generated and stored in artifacts: https://app.bitrise.io/build/84f421b3-09ac-4cf3-8275-4470817c51a8?tab=artifacts
imagen

@junngo
Copy link
Contributor Author

junngo commented Dec 4, 2025

Oh, the file got generated properly. Thank you so much for helping with the code review and testing 🙌
Thanks again @isabelrios :)

@isabelrios
Copy link
Contributor

Oh, the file got generated properly. Thank you so much for helping with the code review and testing 🙌 Thanks again @isabelrios :)

yes it is :) Happy to help! thanks for this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants