Skip to content

Conversation

@ih-codes
Copy link
Collaborator

📜 Tickets

Jira ticket
Github issue

💡 Description

  • Fixes Swift 6 errors in FormAutofillHelperTests
Screenshot 2025-11-28 at 4 13 46 PM

cc @Cramsden @lmarceau @dataports

📝 Checklist

  • I filled in the ticket numbers and a description of my work
  • I updated the PR name to follow our PR naming guidelines
  • I ensured unit tests pass and wrote tests for new code
  • If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • If adding telemetry, I read the data stewardship requirements and will request a data review
  • If adding or modifying strings, I read the guidelines and will request a string review from l10n
  • If needed, I updated documentation and added comments to complex code

@ih-codes ih-codes requested a review from Foxbolts November 28, 2025 22:14
@ih-codes ih-codes requested a review from a team as a code owner November 28, 2025 22:14
@mobiletest-ci-bot
Copy link

💪 Quality guardian

1 tests files modified. You're a champion of test coverage! 🚀

🧹 Tidy commit

Just 1 file(s) touched. Thanks for keeping it clean and review-friendly!

🙌 Friday high-five

Thanks for pushing us across the finish line this week! 🙌

✅ Per-file coverage

All changed files meet the threshold of 35.0%.

Generated by 🚫 Danger Swift against 5f9e8ff

@ih-codes ih-codes merged commit 5cb6a6d into main Dec 1, 2025
9 checks passed
@ih-codes ih-codes deleted the ih/FXIOS-12796-unit-test-client-FormAutofillHelperTests branch December 1, 2025 16:48
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2025

🚀 PR merged to main, targeting version: 146.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants