Repository navigation
Bug 2074412 - Update to ringbuf 0.5.2 - #286
Merged
Merged
Conversation
Mechanical translation to the newer trait methods.
Member
Author
well, I guess I was wrong. |
kinetiknz
approved these changes
Sep 22, 2026
|
|
||
| fn push(&mut self, data: InputCallbackData) { | ||
| self.prod.push(data); | ||
| if self.prod.try_push(data).is_err() { |
Contributor
There was a problem hiding this comment.
push was fallible in ringbuf 0.2, so switching to try_push here without panicking is sufficient.
Contributor
|
0.5.2 had some soundness issues that were fixed in 0.5.3. I don't think this crate or Gecko were affected, but better to update. (We can then also drop the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mechanical translation to the newer trait methods.
Similar to mozilla/cubeb-pulse-rs#115
I don't know if this is all actually correct.
Tests look unchanged
I have two tests not working on the default branch:
they still don't work with this patch.