Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When mono input is expanded to stereo,
BufferManager::pull_data()givespop_slice()the full stereo-sized output slice. With four mono frames queued, a request for two stereo frames consumes all four input frames and silently discards the last two during expansion.Limit both the integer and float reads to
to_pull, the required number of stored input samples, before expanding into the output slice. Add tests that read a mono buffer in two batches and verify the remaining frame count, exact stereo samples, and silence on underrun. Both tests fail before the fix with zero frames remaining instead of two.Found while testing #287, but this is a separate issue also present before the ringbuf 0.5.2 update. This PR is based directly on
trailblazerand does not include the ringbuf race fix.Validation: formatting and Clippy pass; buffer-manager tests pass in debug, release, and AddressSanitizer builds. Full-suite TSan currently has the separate upstream consumer-cache race addressed by #287.