add Ravi support #22
Open
add Ravi support #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starius
force-pushed
the
ravi
branch
5 times, most recently
from
cd7e19e to
dca85db
Compare
|
This looks interesting, thanks! I'll check this out but probably only after 0.7.0 is released with Windows support if you don't mind. |
|
@starius do you plan to update this? I'm fine with supporting only Linux for now. |
|
Rebased. |
|
I've sent a PR with some updates to your fork. |
Ravi support: fixes
|
Thanks! Merged. |
OSX build fails because Python is already installed: https://travis-ci.org/mpeterv/hererocks/jobs/167770746
The former is cross-platform equivalent. Should fix failure in Windows: https://ci.appveyor.com/project/mpeterv/hererocks/build/1.0.179/job/q34tijuxavqlellj
luarocks 2.4.0 fails Lua version check on Windows for "Ravi 5.3" https://ci.appveyor.com/project/mpeterv/hererocks/build/1.0.185/job/dad6rh2cg84y4fhu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It works with luarocks!
TODO: