Skip to content

[Snyk] Fix for 3 vulnerabilities #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mrayanasim09
Copy link
Owner

@mrayanasim09 mrayanasim09 commented Jun 26, 2025

snyk-top-banner

Snyk has created this PR to fix 3 vulnerabilities in the pip dependencies of this project.

Snyk changed the following file(s):

  • requirements.txt
⚠️ Warning
yfinance 0.2.63 requires protobuf, which is not installed.
yfinance 0.2.63 requires websockets, which is not installed.
yfinance 0.2.63 requires curl-cffi, which is not installed.
requests 2.31.0 requires urllib3, which is not installed.
PyQtWebEngine 5.15.6 requires PyQt5, which is not installed.
prophet 1.1.7 requires holidays, which is not installed.
matplotlib 3.5.3 requires fonttools, which is not installed.

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.
  • Some vulnerabilities couldn't be fully fixed and so Snyk will still find them when the project is tested again. This may be because the vulnerability existed within more than one direct dependency, but not all of the affected dependencies could be upgraded.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Open Redirect

Summary by Sourcery

Pin protobuf and urllib3 versions in requirements.txt to remediate security vulnerabilities

Bug Fixes:

  • Pin protobuf to >=4.25.8 to address a reported vulnerability
  • Pin urllib3 to >=2.5.0 to address reported vulnerabilities

This change is Reviewable

@mrayanasim09 mrayanasim09 requested a review from drik-493 as a code owner June 26, 2025 17:02
Copy link

codesandbox bot commented Jun 26, 2025

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

sourcery-ai bot commented Jun 26, 2025

Reviewer's Guide

The PR leverages Snyk’s automated fix to append two new pinned dependencies in requirements.txt (protobuf and urllib3) at secure versions, ensuring vulnerable transitive packages are upgraded without altering existing direct requirements.

Entity relationship diagram for updated pip dependencies

erDiagram
    REQUIREMENTS_TXT {
        string fonttools
        string holidays
        string zipp
        string nltk
        string protobuf
        string urllib3
    }
    REQUIREMENTS_TXT ||--o{ PROTOBUF : includes
    REQUIREMENTS_TXT ||--o{ URLLIB3 : includes
    PROTOBUF {
        string version
    }
    URLLIB3 {
        string version
    }
Loading

Class diagram for requirements.txt dependency structure after Snyk fix

classDiagram
    class RequirementsTxt {
        +fonttools: string
        +holidays: string
        +zipp: string
        +nltk: string
        +protobuf: string
        +urllib3: string
    }
    class Protobuf {
        +version: string
    }
    class Urllib3 {
        +version: string
    }
    RequirementsTxt --> Protobuf : includes
    RequirementsTxt --> Urllib3 : includes
Loading

File-Level Changes

Change Details Files
Pin additional dependencies to secure versions
  • Add protobuf>=4.25.8 to requirements.txt
  • Add urllib3>=2.5.0 to requirements.txt
requirements.txt

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

netlify bot commented Jun 26, 2025

Deploy Preview for heroic-strudel-239c3c failed.

Name Link
🔨 Latest commit 71e88bc
🔍 Latest deploy log https://app.netlify.com/projects/heroic-strudel-239c3c/deploys/685d7d3873c566000814dee3

Copy link

netlify bot commented Jun 26, 2025

Deploy Preview for joyful-gelato-ff27ed failed.

Name Link
🔨 Latest commit 71e88bc
🔍 Latest deploy log https://app.netlify.com/projects/joyful-gelato-ff27ed/deploys/685d7d384d787b0009574fed

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants