Add missing short-circuit functions to result DSL#43
Closed
Conversation
- Add notStarted() function to ResultScope interface - Implement notStarted() in ResultScopeImpl to short-circuit with NotStarted - Update ResultScope KDoc to mention notStarted in the list of provided functions - Add test for notStarted() in AsyncResultResultDslTest
- Add notStarted() function to short-circuit with NotStarted - Add error(Error) overload to short-circuit with Error instance - Add errorWithMetadata() to short-circuit with typed metadata - Update ResultScope KDoc to mention new functions - Add tests for all three new functions
Contributor
|
Owner
Author
|
Superseded by #44 which includes all changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds three missing short-circuit functions to the
ResultScopeDSL:notStarted(): Nothing- Short-circuits withNotStartederror(error: Error): Nothing- Short-circuits with the givenErrorinstance (overload for existingerror(Throwable))errorWithMetadata<T>(metadata: T, errorId: ErrorId?): Nothing- Short-circuits with anErrorcarrying typed metadataChanges
ResultScopeinterface with the three new functionsResultScopeImplThese functions provide more ergonomic ways to short-circuit in the result DSL, especially when working with
Errorinstances directly or when you need to attach typed metadata.Note: Local tests could not be run due to Java runtime unavailability on the development machine, but CI should validate the changes.