Add raw disk/window-size options and harden VM launch scripts#57
Open
HenriqueCrj wants to merge 10 commits into
Open
Add raw disk/window-size options and harden VM launch scripts#57HenriqueCrj wants to merge 10 commits into
HenriqueCrj wants to merge 10 commits into
Conversation
Add qcow2/raw format selection to the VM creation wizard. Create raw disk images through qemu-img and generate launch scripts with the matching QEMU disk format. Detect and preserve raw/qcow2 formats when using existing disks or importing VMs, with tests covering creation, import, and format parsing.
Support raw disk image creation and import
Add a default_window_size setting that serializes as WIDTHxHEIGHT and can be edited from the settings screen. Pass the configured size into VM launches via VM_CURATOR_WINDOW_SIZE and update generated launch scripts to apply supported VGA/device xres/yres overrides at runtime. Patch supported existing launch scripts on launch, keep unsupported or mixed video setups unchanged, and cover the parser, config, UI, script generation, and lifecycle behavior with tests.
Add configurable VM window size override
Fix launch argument persistence and UEFI disk boot priority
# Conflicts: # src/ui/mod.rs # src/ui/screens/shared_folders.rs # src/vm/create.rs # src/vm/single_gpu_scripts.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.raw/.imgfile browser support.qemu-img/QEMU disk format arguments.default_window_sizesetting that passesWIDTHxHEIGHTinto generated/supported launch scripts.Testing
cargo testThis pr that I made only includes the first topic of this summary.
#55