Support images from media library #11
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bglgwyng
changed the title
bglgwyng
force-pushed
the
support-images-from-media-library
branch
from
08bf5ba to
e06fdaf
Compare
mrousavy
requested changes
Jul 8, 2025
Owner
mrousavy
left a comment
mrousavy
left a comment
There was a problem hiding this comment.
Hi - you said this PR is now ready for review, but there is no implementation at all for Android.
This won't even build.
I also left a few comments on code styling, some Swift tips.
mrousavy
reviewed
Jul 8, 2025
Co-authored-by: Marc Rousavy <[email protected]>
Co-authored-by: Marc Rousavy <[email protected]>
Co-authored-by: Marc Rousavy <[email protected]>
Co-authored-by: Marc Rousavy <[email protected]>
bglgwyng
force-pushed
the
support-images-from-media-library
branch
from
04003fc to
a1c92f1
Compare
Contributor
Author
|
@mrousavy Isn't |
bglgwyng
force-pushed
the
support-images-from-media-library
branch
from
0d97270 to
67d87f5
Compare
Owner
|
Sorry I rewrote the whole NitroImage repo.... |
Owner
|
I will try to port that over to the new codebase soon. Sorry |
Owner
|
let's keep it open so I don't forget |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
loadFromAssetAsyncmethod to support load image from media library on iOS