Misc fixes : Synthetic plotting, windowing and padding arguments fixes, forward example.#346
Merged
Conversation
Use `pkg_resources.iter_entry_points` with `importlib.metadata.entry_points` to avoid deprecation warnings and future issues.
…rgs. Added configurable colors for synthetic traces and moment-tensor beachball figures and pass general savefig kwargs through. - waveforms: introduce syn_color (default 'red') on plot_waveforms1/2/3, plot_data_greens*, _plot_stream and _plot_trace so synthetic traces use the provided color instead of hard-coded red. - header: add color parameter to MomentTensorFigureBlock, propagate through build_moment_tensor_header and create_moment_tensor_header, and pass color when rendering beachballs (both inline and via temp file). - beachball: allow extra keyword args to be forwarded to matplotlib's savefig in _plot_beachball_matplotlib.
Also minor changes in DirectEvaluation.py to conform to the generated file.
…idation. Uses `parameters.get()` instead of the old `getattr` implementation fixes the issue (since parameters is a Python dict). Fixes issue #334 Also changed handling of assertion for time_shift_max and min. Checking local variable before assignment.
This propagate all the changes to plotting modes 1, 2 and 3.
Modified color arguments for the beachball plot from "color" to "beachabll_color".
Example usage would be: `beachball_color='red', dat_kwargs={'color': 'gray'}, syn_kwargs={'color': 'blue', 'linestyle': '--'}`
Member
Author
|
If merged, will close and cancel pending PR #331 which would become redundant. Staged merge for the end of the week if no comments. |
This was referenced Apr 27, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am combing through some of the open issues to try to address them.
Addressing issues:
This small PR has no major theme be covers issues:
colorandsyn_color:This particular fix took some cues from PR #331 that has never been finalized.
Other changes:
I also took the liberty to update the way we discover entry point by replacing use pkg_resources which was locking us into
setuptools<82, the code now useimportlib.metadata'sentry_points. This does not modify behaviors, but will remove deprecation warning when usingsetup.py:I also added a new dedicated example for the forward evaluation to address the following issue:
It follow more or less the example script that was provided by @rmodrak in the issue's discussion, with its associated code generator and documentation entry.