Skip to content

[core] Refactor: remove manual displayName #1920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
May 21, 2025
Merged

[core] Refactor: remove manual displayName #1920

merged 10 commits into from
May 21, 2025

Conversation

@romgrk
Copy link
Contributor

@romgrk romgrk commented May 14, 2025 •
edited
Loading

Counter-part of https://github.com/mui/joy-ui/pull/121

Depends on mui/mui-public#329

I forked the babel plugin because the convention here is to add the if-guard.

@romgrk romgrk added core type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. labels May 14, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented May 14, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/@base-ui-components/react@1920

commit: d485b83

@netlify
Copy link

netlify bot commented May 14, 2025

✅ Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit 6098583
🔍 Latest deploy log https://app.netlify.com/sites/base-ui/deploys/6824348d0a72f70008b7ae9e
😎 Deploy Preview https://deploy-preview-1920--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented May 14, 2025 •
edited
Loading

✅ Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit d485b83
🔍 Latest deploy log https://app.netlify.com/projects/base-ui/deploys/682b9c94aeb45e0008c5712b
😎 Deploy Preview https://deploy-preview-1920--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

romgrk
romgrk commented May 14, 2025
View reviewed changes
This was referenced May 14, 2025
Merged
Open
Merged
michaldudak
michaldudak approved these changes May 19, 2025
View reviewed changes
Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let's update the imported dependency location and we can merge it.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label May 19, 2025
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label May 19, 2025
@romgrk romgrk merged commit ab1920e into mui:master May 21, 2025
22 checks passed
@romgrk romgrk deleted the refactor-babel-display-name branch May 21, 2025 21:40
@michaldudak michaldudak added internal scope: all components Widespread work has an impact on almost all components. and removed core labels May 29, 2025
@oliviertassinari oliviertassinari added internal Behind-the-scenes enhancement. Formerly called “core”. and removed core labels Aug 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaldudak michaldudak michaldudak approved these changes

@atomiks atomiks Awaiting requested review from atomiks atomiks is a code owner

@colmtuite colmtuite Awaiting requested review from colmtuite colmtuite is a code owner

Assignees

No one assigned

Labels

internal Behind-the-scenes enhancement. Formerly called “core”. scope: all components Widespread work has an impact on almost all components. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@romgrk @michaldudak @oliviertassinari