-
-
Notifications
You must be signed in to change notification settings - Fork 188
[code-infra] Normalize pkg in codebase #2149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Bundle size report@base-ui-components/react parsed: 0B(0.00%) gzip: 0B(0.00%) Show details for 39 more bundles@base-ui-components/react/accordion parsed: 0B(0.00%) gzip: 0B(0.00%) |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
On comments: both @atomiks and I agree that having these comments is useful. As we're the maintainers, we're the ones who might feel the burden of too many notifications, but we still think it's worth it. It'll be especially useful with #1885. Another solution that could be a good compromise is to have one comment with all the generated content: bundle size, deploy preview and canary packages. Can we please leave the current state until we have the target solution?
What does it have to do with configuration? |
Seeing #2148 (comment) made me want to have all the codebase use the same configuration.
On either the comment should be here or not, the argument that was raised so far is that we should optimize for the DX, which I believe yields the best DX #1865 (comment)