Skip to content

Conversation

yuito-it
Copy link

Implement watch mode to rebuild when source files change by integrating chokidar into the buildTypes script. This enhancement allows for more efficient development by automatically rebuilding on file changes.

This pull request is to implement pnpm dev in the MUI Toolpad repo.

@mui-bot
Copy link

mui-bot commented May 20, 2025

Netlify deploy preview

https://deploy-preview-46180--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 562bb78

@zannager zannager added the type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. label May 21, 2025
@zannager zannager requested a review from Janpot May 21, 2025 10:24
@Janpot
Copy link
Member

Janpot commented May 21, 2025

Looks like a duplicate of #45547. We likely want to avoid duplicating the whole logic in a watcher like that. That will too easily go out of sync with single run as we iterate further on this script.

@yuito-it
Copy link
Author

yuito-it commented May 22, 2025

@Janpot I fixed the problem you tell me. I would appreciate it if you could review this PR.
And I hope merging quickly because this bug affect mui/toolpad dev script.
The toolpad development script uses --watch option :(

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Aug 12, 2025
@oliviertassinari oliviertassinari added the scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd). label Aug 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: out-of-date The pull request has merge conflicts and can't be merged. scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd). type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants