Skip to content

Fix/codemod top level imports 45051 #46405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
+8 −5
Open

Fix/codemod top level imports 45051 #46405

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
237544a
[codemod] Fix conditional check for import specifier whitelist valida…
AidanLDev Jun 22, 2025
976a197
[codemod] Add tests to ensure color imports from @mui/material/colors…
AidanLDev Jun 22, 2025
5e75be6
Merge branch 'master' into fix/codemod-top-level-imports-45051
AidanLDev Jun 22, 2025
2704758
Merge branch 'master' into fix/codemod-top-level-imports-45051
AidanLDev Jun 23, 2025
cf59435
[codemod] Update tests to import from actual.js and expected.js, matc…
Jun 24, 2025
182901c
Merge branch 'master' into fix/codemod-top-level-imports-45051
AidanLDev Jun 24, 2025
9506b7c
[codemod] fix top-level imports tests to preserve color and styles im…
AidanLDev Jun 24, 2025
dd84d53
Merge branch 'master' into fix/codemod-top-level-imports-45051
AidanLDev Jul 4, 2025
6c1d305
[codemod] Removing redundant tests
Jul 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions packages/mui-codemod/src/v5.0.0/top-level-imports.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,10 +69,7 @@ export default function transformer(fileInfo, api, options) {
break;
}
case 'ImportSpecifier':
if (
!whitelist.has(specifier.imported.name) == null &&
specifier.imported.name !== 'withStyles'
) {
if (!whitelist.has(specifier.imported.name) && specifier.imported.name !== 'withStyles') {
return;
}
resultSpecifiers.push(specifier);
Expand Down
3 changes: 3 additions & 0 deletions packages/mui-codemod/src/v5.0.0/top-level-imports.test/actual.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,3 +57,6 @@ import TableFooter from '@mui/material/TableFooter';
import Zoom from '@mui/material/Zoom';
import ClickAwayListener from '@mui/material/ClickAwayListener';
import ListSubheader from '@mui/material/ListSubheader';
import { grey, blue } from '@mui/material/colors';
import { grey as grey2 } from '@mui/material/colors';
import { blue as blue2 } from '@mui/material/colors';
5 changes: 4 additions & 1 deletion packages/mui-codemod/src/v5.0.0/top-level-imports.test/expected.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import { withStyles } from '@mui/styles';

import {
ThemeProvider,
createTheme,
MenuItem,
Tab,
Tabs as MuiTabs,
Expand Down Expand Up @@ -59,3 +58,7 @@ import {
ClickAwayListener,
ListSubheader,
} from '@mui/material';
import { createTheme } from '@mui/material/styles';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is createTheme moved? Is createTheme not included on the whitelist?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question, that's right it's not currently in the whitelist so to get the tests passing I moved it outside of the @mui/material import.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@siriwatknp do you know if this is correct?

import { grey, blue } from '@mui/material/colors';
import { grey as grey2 } from '@mui/material/colors';
import { blue as blue2 } from '@mui/material/colors';