[code-infra] Publish from CI #46851
Open
[code-infra] Publish from CI #46851
+83
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Janpot
added
the
scope: code-infra
Netlify deploy previewhttps://deploy-preview-46851--material-ui.netlify.app/ Bundle size report
|
5 tasks
oliviertassinari
added
security
There was a problem hiding this comment.
I was wonderying why the file publish.yml is not npm-publish.yml to match the environment name (npm-publish). It couldn't make sense of why it's different.
There was a problem hiding this comment.
No specific reason, I included this after building the whole thing and I think I wanted it to stand out a bit more in the barrage of environments that exist in mui/mui-public.
It'll requiring a manual update of every npm package to change this. Not sure it adds enough value to spend the time on this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add CI publishing. This brings provenance and some automation around github releases.
@mui/material-ui Ping me when you know next release happens, so I can make sure I'm around to assist in case there are still misconfigurations