[code-infra] Update ci.yml triggers #46860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Janpot
added
the
scope: code-infra
Netlify deploy previewhttps://deploy-preview-46860--material-ui.netlify.app/ Bundle size report
|
There was a problem hiding this comment.
@oliviertassinari would love a review if you know more about this
I recall we iterated on this problem in #35028, but I didn't understand it. Why is there even a second GitHub Action? Adding ci-check.yml felt broken. I was expecting a logic like this in ci.yml to filter our changes:
material-ui/.circleci/config.yml
Lines 135 to 139 in eabda77
If we can indeed delete
ci-check.yml, great.
| paths-ignore: | ||
| # should sync with ci-check.yml as a workaround to bypass github checks | ||
| - 'examples/**' | ||
| - 'docs/**' |
There was a problem hiding this comment.
I guess we removed this by mistake in https://github.com/mui/material-ui/pull/43315/files#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03fL12
oliviertassinari
added
type: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up after mui/mui-public#632
I believe we could optimize here:
pushinstead of negative, only on release branches, would we need any other?pathsandpaths-ignoreandbranchesandbranches-ignorebetween ci.yml and ci-check.yml. If I understand the linked documentation correctly, the goal is for thetest-devjob in those workflow files to be fully mutually exclusive. (@oliviertassinari would love a review if you know more about this)To do: