[code-infra] Make error code extraction independent of build #46865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brijeshb42
added
the
scope: code-infra
Netlify deploy previewhttps://deploy-preview-46865--material-ui.netlify.app/ Bundle size report
|
brijeshb42
force-pushed
the
extract-error-codes
branch
7 times, most recently
from
4382bee to
b01b080
Compare
brijeshb42
force-pushed
the
extract-error-codes
branch
6 times, most recently
from
72c5ade to
03a2c16
Compare
github-actions
bot
added
the
PR: out-of-date
oliviertassinari
changed the title
brijeshb42
force-pushed
the
extract-error-codes
branch
from
03a2c16 to
5b4c7c9
Compare
github-actions
bot
removed
the
PR: out-of-date
brijeshb42
force-pushed
the
extract-error-codes
branch
from
5b4c7c9 to
449ba14
Compare
Janpot
reviewed
Sep 8, 2025
| '@mui/internal-babel-plugin-minify-errors', | ||
| { | ||
| missingError, | ||
| missingError: 'annotate', |
There was a problem hiding this comment.
We could consider 'throw' here. I believe the idea behind 'annotate' is that in CI you run a search on built files for these annotations, but we don't do that. We can try this later though.
Janpot
reviewed
Sep 8, 2025
| "docs:mdicons:synonyms": "cross-env BABEL_ENV=development babel-node --extensions \".tsx,.ts,.js,.mjs\" ./docs/scripts/updateIconSynonyms && pnpm prettier", | ||
| "docs:zipRules": "cd docs && rm mui-vale.zip && zip -r mui-vale.zip mui-vale && cd ../ && pnpm vale sync", | ||
| "extract-error-codes": "cross-env MUI_EXTRACT_ERROR_CODES=true lerna run --concurrency 1 build:stable", | ||
| "extract-error-codes": "code-infra extract-error-codes --errorCodesPath docs/public/static/error-codes.json --skip @mui/core-downloads-tracker @mui/envinfo @mui/docs @mui/codemod @mui/icons-material", |
There was a problem hiding this comment.
Nice, moving this to a global CLI fixes the concurrency problem. I get why this CLI can be superfast now 🤩
brijeshb42
force-pushed
the
extract-error-codes
branch
from
449ba14 to
500d6ba
Compare
brijeshb42
force-pushed
the
extract-error-codes
branch
from
500d6ba to
8714f5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also migrated
markdownlintcommand to use config fromcode-infra.Main PR - mui/mui-public#641
Perf improvements -
45secin master vs3swith this PR.Can be tweaked further as needed to add/remove packages into/from the extraction process.