[tabs] Disable animation on tab initialization #47008
Closed
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-47008--material-ui.netlify.app/ Bundle size report
|
|
Original PR to be reverted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The effect introduced in #46869 causes a animation when loading and results in very flaky screenshots. This PR just disables the animation in an attempt to stabilize the screenshots. I suppose an animation on load is not intended behavior.
I don't have the bandwidth to dig deep into this, but this component still feels very glitchy. I'd expect the tabs to just initialize in the correct scroll position. Instead there are these flashes of intermediate scroll positions.