-
Notifications
You must be signed in to change notification settings - Fork 28
[code-infra] Add cli to extract error codes independent of build #641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
/* eslint-disable no-console */ | ||
|
||
import { markFn, measureFn } from '../utils/build.mjs'; | ||
|
||
/** | ||
* @typedef {import('../utils/extractErrorCodes.mjs').Args} Args | ||
*/ | ||
|
||
export default /** @type {import('yargs').CommandModule<{}, Args>} */ ({ | ||
command: 'extract-error-codes', | ||
describe: 'Extracts error codes from package(s).', | ||
builder(yargs) { | ||
return yargs | ||
.option('errorCodesPath', { | ||
type: 'string', | ||
describe: 'The output path to a json file to write the extracted error codes.', | ||
demandOption: true, | ||
}) | ||
.option('detection', { | ||
type: 'string', | ||
describe: 'The detection strategy to use when extracting error codes.', | ||
choices: ['opt-in', 'opt-out'], | ||
default: 'opt-in', | ||
}) | ||
.option('skip', { | ||
type: 'array', | ||
describe: 'List of package names to skip.', | ||
default: [], | ||
}); | ||
}, | ||
async handler(args) { | ||
const commandName = /** @type {string} */ (args._[0]); | ||
await markFn(commandName, async () => { | ||
const module = await import('../utils/extractErrorCodes.mjs'); | ||
await module.default(args); | ||
}); | ||
console.log( | ||
`✅ Extracted error codes in ${(measureFn(commandName).duration / 1000.0).toFixed(3)}s`, | ||
); | ||
}, | ||
}); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like
allSettled
wasn't wanted here, theJSON.parse
is already wrapped, and thefs.readFile
we would want to propagate its errors.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My thinking was that we'd want to know about all the erroneous json files in the same run instead of just failing on the first wrong file.
This way, devs can fix the files together instead of running the command multiple times.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would still work, the
JSON.parse
is wrapped intry
/catch
already, and thecatch
just logs. as far as I can see, theallSettled
is not doing anything, except from hiding errors fromfs.readFile
, which is undesired.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. I figured later. Removed the option.