[code-infra] Increase build command type-safety #716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Janpot
added
the
scope: code-infra
Bundle size report
|
Janpot
commented
Sep 17, 2025
| const importPath = originalExports[key]; | ||
| if (!importPath) { | ||
| set(newExports, [key], null); | ||
| return; |
There was a problem hiding this comment.
I believe this should've been continue?
oliviertassinari
temporarily deployed
to
refactor - mui-tools-public PR #716
Render
Destroyed
Janpot
commented
Sep 17, 2025
| * @param {string} param0.outExtension | ||
| * @param {boolean} param0.addTypes | ||
| * @returns {Promise<{path: string[], importPath: string | Record<string, string | undefined>}>} | ||
| * @returns {Promise<void>} |
There was a problem hiding this comment.
Some of the props were applied inside the function, some outside, and some both. Let's just update newExports inside of the function to simplify the flow?
brijeshb42
approved these changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #715
I'm currently messing with the exports code, to reduce the chance of regressions, adding extra types for package.json. Also removed lodash, it's a bit unnecessary,
setbreaks all type safety.I'm adding a few errors for patterns our exports translation doesn't support. Better to explicitly error to warn maintainers early. it also makes type checking work.
Docs infra package seems unaffected