[internal] Remove duplicate eslint rule#4559
Open
oliviertassinari wants to merge 4 commits intomui:masterfrom
Open
[internal] Remove duplicate eslint rule#4559oliviertassinari wants to merge 4 commits intomui:masterfrom
oliviertassinari wants to merge 4 commits intomui:masterfrom
Conversation
| * We do however want to keep the rules in place to ensure the examples are following | ||
| * a reasonably similar code style as the library. | ||
| */ | ||
| files: ['examples/**/*'], |
Member
Author
There was a problem hiding this comment.
Removed, duplicates with https://github.com/mui/material-ui/blob/060c55cb219bfc33633f7e61484884ea6d37bfdf/.eslintrc.js#L529
| extends: ['plugin:testing-library/react'], | ||
| }, | ||
| { | ||
| files: ['docs/src/modules/components/**/*.js'], |
oliviertassinari
added
the
internal
Comment on lines
-61
to
-62
| // TODO move rule into the main repo once it has upgraded | ||
| '@typescript-eslint/return-await': 'off', |
Member
Author
There was a problem hiding this comment.
oliviertassinari
force-pushed
the
simplify-eslint
branch
from
b6c9569 to
93dae5d
Compare
oliviertassinari
force-pushed
the
simplify-eslint
branch
from
93dae5d to
31f9c7e
Compare
oliviertassinari
added
the
scope: code-infra
github-actions
bot
added
the
PR: out-of-date
oliviertassinari
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eslint rule already defined.
The fewer duplicated line of code this file has in Toolpad, the stronger the config in the main repo, the closest to success for the shared config file we are.
I noticed this with #4350.