Open
Conversation
oliviertassinari
added
the
internal
bharatkashyap
approved these changes
Dec 30, 2024
Janpot
reviewed
Jan 7, 2025
| "homepage": "https://github.com/mui/toolpad#readme", | ||
| "scripts": { | ||
| "clean": "rimraf build", | ||
| "clean": "rimraf --glob build \"*.tsbuildinfo\"", |
Member
There was a problem hiding this comment.
The two changes in this PR feel like they're at conflict with each other. Either we generate tsbuildinfo files in the build folder and then the old clean command would suffice. Or we generate them outside of the build folder and then we don't remove them during the copy script. But maybe there are reasons to keep this? I know there are differences in build between studio packages and core packages.
github-actions
bot
added
the
PR: out-of-date
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as mui/base-ui#1245