Skip to content

feat(bi-service): Add BI services, enums, and Excel upload functionality#33

Merged
ilramdhan merged 4 commits into
mutugading:mainfrom
ilramdhan:feat/bi-foundation
May 28, 2026
Merged

feat(bi-service): Add BI services, enums, and Excel upload functionality#33
ilramdhan merged 4 commits into
mutugading:mainfrom
ilramdhan:feat/bi-foundation

Conversation

@ilramdhan

Copy link
Copy Markdown
Member

Description

Add foundational BI protobuf contracts including enums, entity messages, BI service definitions, and Excel upload/audit RPC support for dashboard integration.

This PR introduces the initial BI proto architecture with:

  • Core BI entity/message definitions
  • Full RPC contracts for BI services
  • Excel upload workflow services
  • Config audit log RPCs
  • Supporting upload/audit entities

Change Type

  • ✨ New service/message
  • ➕ Add field/RPC/enum value
  • 🔄 Modify validation
  • 📝 Documentation update
  • ⚠️ Deprecation
  • 🔧 Config/script changes

Proto Files Changed

  • common/v1/common.proto
  • finance/v1/uom.proto
  • Other:
    • bi/v1/bi.proto
    • Additional BI-related proto definitions

Changes Made

  • Add BI enums and core entity messages in bi.proto
  • Add 4 BI services with complete RPC contracts
  • Add BiUploadService RPCs:
    • DownloadUploadTemplate
    • ParseUpload
    • CommitUpload
    • CancelUpload
    • ListUploads
  • Add ListConfigAudit RPC to DashboardService
  • Add supporting messages:
    • BiUpload
    • UploadRowError
    • BiAuditEntry
  • Add dashboard Excel upload workflow support
  • Add config audit log feature contracts
  • Sync latest main branch updates into feat/bi-foundation

Related Issues

Fixes #
Related to #

Breaking Change Check

Is this a breaking change?

  • No - buf breaking passes
  • Yes - Requires version bump

Breaking Change Evidence

# Output of buf breaking command
buf breaking --against '.git#branch=main'

Lint Check

# Output of buf lint
buf lint

Generated Code Preview (Optional)

// Generated Go code changes
// Added BI service clients and server interfaces
// Added upload/audit protobuf message structs
// Added RPC request/response generated types

Pre-merge Checklist

  • I have read and followed RULES.md
  • buf format -w applied
  • buf lint passes
  • buf breaking passes
  • Comments document new messages/fields
  • REST mappings follow conventions
  • Validation rules are complete
  • Field numbers are logical

Impact Assessment

  • Backend code regeneration required
  • Frontend code regeneration required
  • OpenAPI spec regeneration required

Reviewer Notes

  • This PR focuses on BI proto foundation and service contracts only.
  • Upload workflow RPCs are designed for dashboard Excel import flows.
  • Audit RPCs support future dashboard configuration traceability.
  • Includes merge sync from latest main.

ilramdhan and others added 4 commits May 26, 2026 19:29
Add BiUploadService (DownloadUploadTemplate/ParseUpload/CommitUpload/
CancelUpload/ListUploads) and a ListConfigAudit RPC on DashboardService,
plus BiUpload, UploadRowError, and BiAuditEntry messages — backing the
dashboard Excel-upload and config-change audit-log features.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@ilramdhan ilramdhan added this to the Costing Release Milestone milestone May 28, 2026
@ilramdhan ilramdhan self-assigned this May 28, 2026
Copilot AI review requested due to automatic review settings May 28, 2026 01:42
@ilramdhan ilramdhan added the feat label May 28, 2026
@ilramdhan ilramdhan moved this from Todo to In progress in Goapps Roadmap [Shared-Proto] May 28, 2026
@ilramdhan ilramdhan merged commit da246b7 into mutugading:main May 28, 2026
1 check passed
@github-project-automation github-project-automation Bot moved this from In progress to Done in Goapps Roadmap [Shared-Proto] May 28, 2026
@ilramdhan ilramdhan review requested due to automatic review settings May 28, 2026 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

1 participant