fix(bi-dashboard): add BiJob RPCs and enhance Dashboard features#35
Merged
Conversation
…Dashboards RPC - Dashboard message: fields 25 (is_featured) and 26 (feature_order) - UpdateDashboardRequest: optional is_featured/feature_order for pin/unpin - New ListFeaturedDashboards RPC: GET /api/v1/finance/bi/dashboards/featured Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ilramdhan
changed the title
github-project-automation
Bot
moved this from In progress
to Done
in Goapps Roadmap [Shared-Proto]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request expands the BI (Business Intelligence) proto definitions to support featured dashboards and adds full CRUD (Create, Read, Update, Delete) support for BI jobs. The changes introduce new fields and RPC methods to improve dashboard management and enable dynamic ETL job operations.
Change Type
Proto Files Changed
finance/v1/bi.protoChanges Made
Dashboard enhancements:
is_featuredandfeature_orderfields to theDashboardmessage, allowing dashboards to be marked and ordered as featured. These fields are also included in theUpdateDashboardRequestmessage. [1] [2]ListFeaturedDashboardsRequest,ListFeaturedDashboardsResponse, and theListFeaturedDashboardsRPC in theDashboardService. [1] [2]BI job management:
CreateBiJobRequest,CreateBiJobResponse,UpdateBiJobRequest,UpdateBiJobResponse,DeleteBiJobRequest, andDeleteBiJobResponse, with appropriate validation rules.BiJobServicefor registering, updating, and soft-deleting BI jobs, with REST endpoint mappings.Pre-merge Checklist
buf format -wappliedbuf lintpassesbuf breakingpassesImpact Assessment