feat(finance,iam): introduce fill-assignment services, auth unlock, and notification rules#36
Merged
Merged
Conversation
…nstance_id - New finance/v1/cost_fill_assignment.proto: CostLevelAssignmentConfigService (UpsertLevelConfig, DeleteGlobalConfig, ListGlobalConfigs) and CostFillTaskService (ListFillTasks, ClaimFillTask, SubmitFillTask, ApproveFillTask, RejectFillTask) with FillTask/FillApproval/ LevelAssignmentConfig messages and FillTaskStatus/FillActorType enums - iam/v1/auth.proto: add ValidateUnlockPassword RPC + messages for re-confirming identity from JWT context without a user_id param - finance/v1/cost_product_request.proto: add wfl_instance_id field (30) to CostProductRequest for IAM workflow instance linkage Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…tification service Adds RecipientRuleType enum, RecipientRule message, RequestNotificationRequest/Response messages, and a RequestNotification RPC to NotificationService for rule-based multi-recipient cross-service notification dispatch. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…y message Adds the approval trace endpoint for cost product requests. The new RPC returns the full status-transition timeline, enabling the A6 approval trace UI on the frontend. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Add fields 12 (section_code) and 13 (department_code) to AuthUser for DEPT filler eligibility checks in fill assignment UI. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ilramdhan
added
documentation
github-project-automation
Bot
moved this from Todo
to Done
in Goapps Roadmap [Shared-Proto]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR ini menggabungkan beberapa penambahan fitur pada shared protobuf lintas domain (
financedaniam). Pembaruan utama mencakup pembuatan service baru untukCost Fill Assignment, penambahan RPC notifikasi berbasis aturan (RecipientRule) di IAM, endpoint pelacakan riwayat approval padaCost Product Request(UI Trace A6), serta penyesuaian detail identitas user (AuthUser) dan auth unlock.Change Type
Proto Files Changed
finance/v1/cost_fill_assignment.proto(New File)finance/v1/cost_product_request.protoiam/v1/auth.protoiam/v1/notification.protoChanges Made
cost_fill_assignment.protobesertaCostLevelAssignmentConfigService(Upsert, Delete, List) danCostFillTaskService(List, Claim, Submit, Approve, Reject).wfl_instance_id(30) untuk integrasi IAM workflow dan RPCGetCostProductRequestHistorybeserta messageStatusHistoryEntryuntuk kebutuhan UI approval trace A6.ValidateUnlockPassworduntuk konfirmasi ulang identitas via JWT context dan fieldsection_code(12) sertadepartment_code(13) pada messageAuthUseruntuk validasi kelayakan filler.RequestNotificationbeserta message/enumRecipientRuleuntuk mekanisme dispatch notifikasi lintas layanan dengan multi-recipient.Related Issues
Fixes #
Related to # (Task 6 A3), # (A6 Approval Trace UI)
Breaking Change Check
Is this a breaking change?
buf breakingpassesBreaking Change Evidence
Lint Check
# Output of buf lint buf lintGenerated Code Preview (Optional)
// Menunggu proses pipeline atau local generate.Pre-merge Checklist
buf format -wappliedbuf lintpassesbuf breakingpassesImpact Assessment
Reviewer Notes
Perubahan bersifat murni penambahan (backward-compatible). File
cost_fill_assignment.protoadalah file baru, pastikan aturan linting pada penamaan service dan message sudah sesuai dengan standar konvensi. Backend dan Frontend perlu segera melakukan pull dan generate code ulang setelah PR ini di-merge agar dapat menggunakan RPC dan field terbaru.