Skip to content

fix: update focus-visible box-shadow to use CSS variable#1279

Merged
ronald-urbina merged 1 commit intomuxinc:mainfrom
Th3S4mur41:fix/media-text-focus-color
Apr 8, 2026
Merged

fix: update focus-visible box-shadow to use CSS variable#1279
ronald-urbina merged 1 commit intomuxinc:mainfrom
Th3S4mur41:fix/media-text-focus-color

Conversation

@Th3S4mur41
Copy link
Copy Markdown
Contributor

@Th3S4mur41 Th3S4mur41 commented Mar 26, 2026

closes #1278

This pull request makes a minor update to the focus styling in the media-text-display component, allowing the box shadow to be customized via a CSS variable.

  • Accessibility and customization:
    • src/js/media-text-display.ts: Updated the :host(:focus-visible) selector to use the --media-focus-box-shadow CSS variable, enabling easier customization of the focus box shadow.

Note

Low Risk
A small, CSS-only change limited to focus-visible styling; functional behavior is unchanged aside from allowing theming overrides.

Overview
Updates media-text-display focus styling so :host(:focus-visible) uses a configurable CSS custom property (--media-focus-box-shadow) with the previous inset shadow as the fallback.

Written by Cursor Bugbot for commit 5c97f11. This will update automatically on new commits. Configure here.

@Th3S4mur41 Th3S4mur41 requested review from a team and heff as code owners March 26, 2026 12:44
@vercel
Copy link
Copy Markdown

vercel bot commented Mar 26, 2026

@Th3S4mur41 is attempting to deploy a commit to the Mux Team on Vercel.

A member of the Team first needs to authorize it.

@snyk-io
Copy link
Copy Markdown

snyk-io bot commented Mar 26, 2026

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.58%. Comparing base (3ea80df) to head (5c97f11).
⚠️ Report is 295 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1279      +/-   ##
==========================================
- Coverage   78.55%   73.58%   -4.97%     
==========================================
  Files          59       56       -3     
  Lines       11080    13873    +2793     
  Branches        0      783     +783     
==========================================
+ Hits         8704    10209    +1505     
- Misses       2376     3631    +1255     
- Partials        0       33      +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ronald-urbina ronald-urbina merged commit 4975ab8 into muxinc:main Apr 8, 2026
7 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] media-time-display is not using --media-focus-box-shadow

2 participants